Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Update reference to window object for Redux Dev tools #10868

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Admin Page: Update reference to window object for Redux Dev tools #10868

merged 1 commit into from
Dec 7, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 7, 2018 •
edited
Loading

The reference to the middleware high order function is now __REDUX_DEVTOOLS_EXTENSION__ .

Fixes warning in the console when Redux dev tools are available.

Changes proposed in this Pull Request:

  • Updates reference from window.devToolsExtension to window.__REDUX_DEVTOOLS_EXTENSION__.

Testing instructions:

  1. Checkout this branch
  2. Load the admin page with the Redux dev tools extension installed
  3. Confirm you don't see a warning like window.devToolsExtension is deprecated in favor of window.__REDUX_DEVTOOLS_EXTENSION__, and will be removed in next version of Redux DevTools: https://git.io/fpEJZ

Proposed changelog entry for your changes:

  • None needed

@oskosk oskosk added [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial labels Dec 7, 2018
@oskosk oskosk requested a review from a team as a code owner December 7, 2018 00:57
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

@oskosk oskosk requested review from jeherve and brbrr December 7, 2018 01:00
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 7, 2018
jeherve
jeherve approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 🚢

brbrr
brbrr approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thanks!

@jeherve jeherve merged commit fb9f1a4 into master Dec 7, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 7, 2018
@jeherve jeherve deleted the update/redux-dev-tools-middleware-name branch December 7, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@brbrr brbrr brbrr approved these changes

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oskosk @jetpackbot @jeherve @brbrr @matticbot