Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled Gallery block: Add server render srcset #11397
Tiled Gallery block: Add server render srcset #11397
Changes from all commits
8abd0c3
d5b7247
a034eb0
e2ca410
a1054f1
4d64f32
cecce29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we at this point just see square images anyway since that's how they're saved from the editor, without even checking for the type of layout?
I'm hoping we would not need this
if/else
here at all and this section would be more simple.This might be useful here, too: https://developer.wordpress.org/reference/functions/wp_constrain_dimensions/
That said, totally not a blocker and ok to merge as-is. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the branch with a lot of very similar code is appealing, but also a fair bit of work for little benefit. I looked at it when implementing these changes and considered this was good enough.
I can take another look (or you're welcome to) if you think it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, merging and deploying is more fun than reworking this out. 👍