Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings - Writing: add toggle for Shortcode Embeds #12092

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Settings - Writing: add toggle for Shortcode Embeds #12092

merged 1 commit into from
Apr 22, 2019

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Apr 18, 2019 •
edited
Loading

Fixes #11934

Changes proposed in this Pull Request:

  • add a toggle to the Composing group to activate Shortcodes
  • make the feature searchable, even separated from other features in Composing
  • remove searchable module
  • don't activate Shortcode Embeds module by default

Testing instructions:

  • starting with a new site, Shortcode Embeds must not be active by default
  • Go to Jetpack settings, Writing > Composing. Verify the toggle is there and that it works
  • Try searching for shortcodes or any word in the shortcodes.php module header, it should appear in the search results

Captura de Pantalla 2019-04-18 a la(s) 18 16 05

Proposed changelog entry for your changes:

@eliorivero
Settings - Writing: add toggle for Shortcodes. Make it searchable, re…
0c949b3 
…move searchable module. Don't activate shortcodes by default.
@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Apr 18, 2019
@eliorivero eliorivero added this to the 7.3 milestone Apr 18, 2019
@eliorivero eliorivero requested a review from a team as a code owner April 18, 2019 21:16
@eliorivero eliorivero self-assigned this Apr 18, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 0c949b3

oskosk
oskosk approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 18, 2019
@eliorivero eliorivero merged commit 6dad7c5 into master Apr 22, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 22, 2019
@eliorivero eliorivero deleted the add/settings-shortcodes branch April 22, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Settings - Create Shortcode embeds setting
5 participants
@eliorivero @jetpackbot @oskosk @kraftbj @matticbot