Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP: check if class exists before to use it. #12140

Merged
merged 1 commit into from
Apr 24, 2019
Merged

AMP: check if class exists before to use it. #12140

merged 1 commit into from
Apr 24, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 24, 2019

Changes proposed in this Pull Request:

This is a follow-up to #12139 for more files in sync with WordPress.com.

More changes like that will also happen in #11814 and #12096.

Testing instructions:

  • Try to use Likes.
  • Try to use the contact info widget.
  • Both should look good on the frontend.

Proposed changelog entry for your changes:

  • None.

@jeherve
AMP: check if class exists before to use it.
4970b3d 
This is a follow-up to #12139 for more files in sync with WordPress.com.
@jeherve jeherve added [Feature] Likes [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial AMP labels Apr 24, 2019
@jeherve jeherve requested a review from a team April 24, 2019 14:26
@jeherve jeherve self-assigned this Apr 24, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 4970b3d

@jeherve
Copy link
Member Author

jeherve commented Apr 24, 2019

Those 2 files are quite out of sync with WordPress.com, so will need to be synced up manually in D27333-code.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 24, 2019
@jeherve jeherve merged commit 0d600fe into master Apr 24, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 24, 2019
@jeherve jeherve deleted the update/amp-check-take-2 branch April 24, 2019 16:48
@jeherve jeherve mentioned this pull request May 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
AMP [Feature] Extra Sidebar Widgets [Feature] Likes [Status] Tested on WP.com Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @kraftbj @matticbot