Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding checksums to Jetpack_JSON_API_Sync_Status_Endpoint #12209
Adding checksums to Jetpack_JSON_API_Sync_Status_Endpoint #12209
Changes from all commits
0740a5c
319caae
ae831e0
ed3509c
ac1d2f8
613bad5
38d9e72
6acc00a
ca0dc32
efbcf2a
468707a
cf1aed2
eaf6efb
35bb1f5
e61df46
2df11c9
eb4e1c5
6a07cc0
550f88f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if fields was always an array. instead of sometimes an array and sometimes a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a helper function. Query params need to be strings anyway and I think this is the most straightforward way to handle things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also support both
array
andstring
(like many other WP core functions and methods do), but we should make sure that's properly supported by adding specific tests for that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we don't need that because this is just a helper function used in a single JSON API response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we never really using anything but a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about one test per
Jetpack_Sync_Actions::get_sync_status
call?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple assertions in a single test is something I've considered to be fine until now.
As stated before, it's just testing a single concept. I'd love to have a simpler way to write this while maintaining human-readability, but PHPUnit doesn't seem to allow it.