-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through the from
parameter when connecting an already connected Jetpack
#12351
Conversation
This is an automated check which relies on |
Thanks for the reviews! I've moved the line inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work. I only have a minor request until we have a whitelist of parameters.
Unblocking for now; as @tyxla mentioned it can be addressed in a future PR. @justinshreve You can merge whenever you're ready :) |
Follow-up from #12351 Since one can currently pass any "from" parameter when building that URL, let's sanitize that value.
…2380) * Connect flow: sanitize "from" parameter when building connect url Follow-up from #12351 Since one can currently pass any "from" parameter when building that URL, let's sanitize that value. * Connect URL: allow the use of periods in from parameter See #12380 (comment) Co-Authored-By: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Connect URL: escape full URL instead of sanitizing one parameter Co-authored-by: Eric Binnion <ericbinnion@gmail.com>
If a user tries to connect Jetpack when the are already connected, they are redirected back to the onboarding flow in Calypso. See #3788.
Currently, if a
from
parameter is supplied (likewoocommerce-setup-wizard
), this is lost during the redirect. We are going to start using this parameter in Calypso to show some different copy/design elements during the flow, so passing this along will help users who hit this edge case.To Test:
from
is also passed on retry. https://github.com/Automattic/wp-calypso/pull/32993/files#diff-4082b3f22f0a998cdc936b484d8ea8f9 and https://github.com/Automattic/wp-calypso/pull/32993/files#diff-ff76e1701bebf84cf3e5a847ffd165d0R171.&from=woocommerce-setup-wizard
and make sure it persists back to Calypso (purple styles should be retained).