Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery: Remove invalidating strip attribute from block save #12390

Merged
merged 1 commit into from
May 16, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 16, 2019

Adding ?strip=all to the img[src] causes block invalidation. Revert
this invalidating change.

Introduced in #12061, discovered in D26982-code

Testing instructions:

Block validation: Expected attribute `src` of value `https://example.com/image.jpg?strip=all`, saw `https://example.com/image.jpg`.

Will be handled as part of D26982-code.

Proposed changelog entry for your changes:

None

Adding ?strip=all to the `img[src]` causes block invalidation. Revert
this invalidating change.
@sirreal sirreal added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Tiled Gallery labels May 16, 2019
@sirreal sirreal requested a review from a team May 16, 2019 09:47
@sirreal sirreal requested a review from a team as a code owner May 16, 2019 09:47
@sirreal sirreal self-assigned this May 16, 2019
@sirreal sirreal changed the title Remove strip attribute from block save Tiled Gallery: Remove invalidating strip attribute from block save May 16, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 90689df

@sirreal sirreal added this to the 7.4 milestone May 16, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 16, 2019
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested in D26982-code

@sirreal sirreal merged commit a3986fc into master May 16, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 16, 2019
@sirreal sirreal deleted the update/no-tiled-gallery-strip-invalidation branch May 16, 2019 12:44
@simison
Copy link
Member

simison commented May 17, 2019

r191914-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants