Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Plan: Remove features CTAs #12430

Merged
merged 1 commit into from
May 21, 2019
Merged

My Plan: Remove features CTAs #12430

merged 1 commit into from
May 21, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 21, 2019 •
edited
Loading

Companion to #12429, part of #11997 (comment)

Remove the primary buttons from My Plan feature cards. There were some cases of multiple primary buttons which is discouraged. The only primary button will be in the header as of #12429

Screens

Before

before

After

after

Testing instructions:

  • From /wp-admin/admin.php?page=jetpack#/my-plan on your Jetpack site
  • There should be no primary buttons in the features for different plans like in the after screenshot above.
  • No other changes.

@sirreal sirreal requested a review from a team as a code owner May 21, 2019 12:37
@sirreal sirreal mentioned this pull request May 21, 2019
Merged
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 0839ac8

@sirreal sirreal requested review from jeffgolenski and a team May 21, 2019 12:40
@sirreal sirreal self-assigned this May 21, 2019
@sirreal sirreal added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! [Type] Task Plans labels May 21, 2019
@sirreal sirreal added this to the 7.4 milestone May 21, 2019
jeherve
jeherve approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. 🚢

@jeherve jeherve removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 21, 2019
jeffgolenski
jeffgolenski approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels May 21, 2019
@kraftbj kraftbj merged commit d8742a8 into master May 21, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 21, 2019
@kraftbj kraftbj deleted the remove/my-plan-feature-ctas branch May 21, 2019 20:19
@sirreal sirreal mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffgolenski jeffgolenski jeffgolenski approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@sirreal sirreal

Labels
Plans [Type] Task
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
6 participants
@sirreal @jetpackbot @jeffgolenski @jeherve @kraftbj @matticbot