Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Add a premium block category #12431

Closed
wants to merge 2 commits into from

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented May 21, 2019

Changes proposed in this Pull Request:

  • This adds a new "Premium" category to the block picker:

Screenshot 2019-05-21 at 13 59 20

This makes it clear that these blocks are paid blocks, not free ones.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is part of Page Editor Plus: paAmJe-ll-p2

Testing instructions:

  • Go to the post editor for a site with no plan
  • Check that you don't see the Premium section
  • Go to the post editor for a site with a plan
  • Check that the Simple Payments button appears in a new category in the block picker:

Screenshot 2019-05-21 at 13 59 20

Proposed changelog entry for your changes:

  • no changelog needed

@scruffian scruffian added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels May 21, 2019
@scruffian scruffian requested a review from a team as a code owner May 21, 2019 13:12
@scruffian scruffian self-assigned this May 21, 2019
@jetpackbot
Copy link

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 8e33a11

@kraftbj kraftbj added the [Status] Needs Design Review Design has been added. Needs a review! label May 21, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28489-code before merging this PR. Thank you!

@kraftbj kraftbj added the [Status] Needs Product Review Consider posting about this on an internal P2 for discussion label May 21, 2019
@kraftbj
Copy link
Contributor

kraftbj commented May 21, 2019

Adding a request for design review since it impacts design and asking for a product review since there's not a link to a discussion about it, so not sure if product is looped in.

@eeeeevon13
Copy link
Contributor

I think from a usability standpoint it might be helpful to name it "Jetpack Premium" instead of just "Premium" the icon alone doesn't follow the pattern above "Jetpack [icon]". https://imgur.com/a/whD0uU2
Aside from that the test did work for me.

@scruffian
Copy link
Member Author

We're not going to change anything in the picker as it's too intertwined with other issues.

@scruffian scruffian closed this May 24, 2019
@scruffian scruffian deleted the add/premium-block-category branch May 24, 2019 18:57
@kraftbj kraftbj removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Product Review Consider posting about this on an internal P2 for discussion Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants