Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev Environment: add Composer to the required tools #12469

Merged
merged 1 commit into from
May 27, 2019
Merged

Dev Environment: add Composer to the required tools #12469

merged 1 commit into from
May 27, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 27, 2019

Changes proposed in this Pull Request:

  • Now that we rely on Composer a lot more, it's best to mention it so new contributors know to install it.

Testing instructions:

  • Not much to test here.

Proposed changelog entry for your changes:

  • None

@jeherve
Dev Environment: add Composer to the required tools
c1d834f 
Now that we rely on Composer a lot more, it's best to mention it so new contributors know to install it
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Docs [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Jetpack DNA labels May 27, 2019
@jeherve jeherve added this to the 7.4 milestone May 27, 2019
@jeherve jeherve requested a review from brbrr May 27, 2019 08:56
@jeherve jeherve requested a review from a team as a code owner May 27, 2019 08:56
@jeherve jeherve self-assigned this May 27, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against c1d834f

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 27, 2019
@jeherve jeherve merged commit 343f990 into master May 27, 2019
@jeherve jeherve deleted the add/composer-docs branch May 27, 2019 11:00
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

Assignees

@jeherve jeherve

Labels
Docs [Focus] Jetpack DNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @brbrr @matticbot