Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms to return value in existing Post backup endpoint #12696

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

thingalon
Copy link
Member

When fetching a post object backup, include linked terms via the term_relationships table.

Changes proposed in this Pull Request:

This PR adds a terms key to the result of the Post Backup API endpoint, which includes a summary of the linked term relationships associated with the requested Post Object.

Reference: pa0RFL-jR-p2

Testing instructions:

Execute the post backup endpoint via the wpcom API, and verify that the resultant output includes associated term relationships.

See pa0RFL-jR-p2 for more details.

Proposed changelog entry for your changes:

  • Include updates to term relationships when backing up Post object changes.

@thingalon thingalon added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 14, 2019
@thingalon thingalon requested a review from a team as a code owner June 14, 2019 12:22
@thingalon thingalon self-assigned this Jun 14, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against fd6f56d

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Vault [Feature] WPCOM API labels Jun 15, 2019
@jeherve jeherve added this to the 7.5 milestone Jun 15, 2019
Copy link
Contributor

@seear seear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I tested from my VaultPress sandbox also using wpcom patch D29457 D29460 and saw the new terms field:

    "terms": [
        {
            "term_taxonomy_id": "2",
            "term_order": "0"
        }

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. Merge when ready.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 19, 2019
@dereksmart dereksmart merged commit 9668cc6 into master Jun 19, 2019
@dereksmart dereksmart deleted the update/include-terms-in-post-backups branch June 19, 2019 16:07
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 19, 2019
jeherve added a commit that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backup & Scan [Feature] WPCOM API [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants