Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic: site verification verbiage change #12761

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Traffic: site verification verbiage change #12761

merged 1 commit into from
Jun 19, 2019

Conversation

scottsweb
Copy link
Contributor

Clear setting description for site verification card

Fixes #12623

See original issue for before and after screenshots

Testing instructions:

  • Go to wp-admin/admin.php?page=jetpack#/traffic
  • Confirm setting copy is updated

Proposed changelog entry for your changes:

  • None

@scottsweb scottsweb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Jun 19, 2019
@scottsweb scottsweb requested a review from a team as a code owner June 19, 2019 13:37
@scottsweb scottsweb self-assigned this Jun 19, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 31d8a16

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 19, 2019
@jeherve jeherve added this to the 7.5 milestone Jun 19, 2019
@jeherve jeherve merged commit e9f8c64 into master Jun 19, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 19, 2019
@jeherve jeherve deleted the fix/12623-verification branch June 19, 2019 14:22
jeherve pushed a commit that referenced this pull request Jun 27, 2019
@scottsweb @jeherve
Traffic: site verification verbiage change (#12761)
523ba0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@scottsweb scottsweb

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.5
Development

Successfully merging this pull request may close these issues.

Traffic: Site Verification copy
4 participants
@scottsweb @jetpackbot @jeherve @matticbot