Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Climate: Update Rules #13468

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Code Climate: Update Rules #13468

merged 2 commits into from
Oct 17, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 15, 2019

WIP: Opening this so we can continue the discussion of rules to exclude or modify.

Adding changes to Code Climate to match what maintenance checks we'd like to use at this time.

See https://docs.codeclimate.com/docs/advanced-configuration

Changes proposed in this Pull Request:

  • Disables the method length check.

Testing instructions:

  • n/a

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial labels Sep 15, 2019
@kraftbj kraftbj requested a review from a team as a code owner September 15, 2019 02:14
@kraftbj kraftbj self-assigned this Sep 15, 2019
@jetpackbot

This comment has been minimized.

Sign in to view
@jeherve
Copy link
Member

jeherve commented Sep 15, 2019

I think we may want to do the same for file-lines, since it's often not something that is really valuable.

@pento pento mentioned this pull request Oct 14, 2019
Merged
@jeherve jeherve mentioned this pull request Oct 16, 2019
Merged
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 17, 2019

There are probably more, but at least let's land this and we can iterate as we have more mental cycles to give to this.

@kraftbj kraftbj added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 17, 2019
@kraftbj kraftbj added this to the 7.9 milestone Oct 17, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 17, 2019
@kraftbj kraftbj merged commit 2cf86a2 into master Oct 17, 2019
@kraftbj kraftbj deleted the update/codeclimate branch October 17, 2019 11:03
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 17, 2019
@enejb
Copy link
Member

enejb commented Oct 17, 2019

Thanks for these changes! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
5 participants
@kraftbj @jetpackbot @jeherve @enejb @matticbot