-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related posts block - updated margin to make full-width #13839
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: November 5, 2019. |
Is this needed for every theme out there? If so, where are the 10px added in the first place? Is that some CSS we could remove in Jetpack? |
@jeherve It is needed for every theme. The 10px margin is on each Related Post Item applied to both left and right sides which puts some needed space between them. This simple aligns the outer edges correctly no matter the number of items in the grid. |
I noticed that the Related Posts block is indented 10px on the left and right side of whatever column it resides in. I added some negative margins as a quick hack to resolve this. In theory, now the column will line up.
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Before
After
Testing instructions:
Note: There is some additional margin added by the theme. This is taken care of in #13516
Proposed changelog entry for your changes: