Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: link to Jetpack or wpcom support docs depending on site type #13902

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Blocks: link to Jetpack or wpcom support docs depending on site type #13902

merged 1 commit into from
Nov 4, 2019

Conversation

simison
Copy link
Member

@simison simison commented Oct 30, 2019 •
edited
Loading

Link to Jetpack or WordPress.com support articles depending on site type.

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

  • Insert Markdown and Simple payments block and confirm that for a Jetpack site, you have links to Jetpack docks:

image

image

Proposed changelog entry for your changes:

@simison simison requested a review from a team October 30, 2019 21:27
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D34785-code before merging this PR. Thank you!

@simison simison added [Pri] Low [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Feature] Markdown Simple Payments labels Oct 30, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 0d898d4

@simison simison added this to the 8.0 milestone Oct 31, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 31, 2019
@kraftbj kraftbj merged commit 96d06ee into master Nov 4, 2019
@kraftbj kraftbj deleted the update/support-links-env branch November 4, 2019 17:50
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 4, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Nov 4, 2019

r198887-wpcom

@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Block] Pay With Paypal aka Simple Payments [Feature] Markdown [Feature] Pay with PayPal aka Simple Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Low Touches WP.com Files
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@simison @matticbot @jetpackbot @kraftbj @jeherve