Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-CLI: Add block preview support to the block scaffolding template #13951

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

pento
Copy link
Contributor

@pento pento commented Nov 4, 2019

Since we want all blocks to have previews, it'd be useful to include block preview support in the WP-CLI block scaffolding template, so new blocks don't accidentally forget it (like I did in #13905).

Changes proposed in this Pull Request:

  • Add an example property to the settings object in the block index.js mustache template.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is an enhancement to the existing wp jetpack scaffold block WP-CLI command.

Testing instructions:

  • Run wp jetpack scaffold block "My Block".
  • Confirm that settings.example exists in the block's index.js.
  • Confirm that a preview for the block shows in the block selector.

Proposed changelog entry for your changes:

  • CLI: Add block preview support to the wp jetpack scaffold block command.

@pento pento added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Jetpack CLI labels Nov 4, 2019
@pento pento added this to the 8.0 milestone Nov 4, 2019
@pento pento requested a review from a team November 4, 2019 03:18
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against f18fafd

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 4, 2019
@kraftbj kraftbj merged commit c26bee1 into master Nov 4, 2019
@kraftbj kraftbj deleted the add/block-scaffold-preview-support branch November 4, 2019 17:49
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Jetpack CLI [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants