-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Update keywords for better search results #14658
Conversation
Changes and adds keywords to a few blocks that will hopefully be easier to find now.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left two comments but I wouldn't mind if this PR got in as is. Already a big improvement and we can (and will) continue making changes in this area further. I've also tested the wpcom diff and it matches described changes
Just because `map` is part of `maps` in English, doesn't mean that that'll be the case in all languages. Props @marekhrabe
obenland, Your synced wpcom patch D38792-code has been updated. |
@jeherve I'm not sure who's in charge of Thanks for your review, I think this is ready for another round. |
We'll use core's update
obenland, Your synced wpcom patch D38792-code has been updated. |
It is :) The tool is part of Fusion, which helps us keep Jetpack and wpcom in sync.
Correct. That's something we have yet to implement. For now, that means that once this PR is merged here in Jetpack, you'll need to copy the file over to your sandbox manually,
xx being all the unbuilt files you've modified / added. Edit: and I now see you've removed the filter. Don't mind me :) |
Changes and adds keywords to a few blocks that will hopefully be easier to find now.
Fixes #14628.
Changes proposed in this Pull Request:
map
keyword tomaps
in Map block. This will allow for both strings to return a result in the block selector.social
keyword to Pinterest block.Is this a new feature or does it add/remove features to an existing part of Jetpack?
See Quick Wins in paYJgx-qn-p2.
Testing instructions:
yarn build-extensions
to compile these changes.wp.blocks.getBlockType('core-embed/crowdsignal')
and check to see that the "survey" keyword was added.Proposed changelog entry for your changes: