Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Update keywords for better search results #14658

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

obenland
Copy link
Member

Changes and adds keywords to a few blocks that will hopefully be easier to find now.

Fixes #14628.

Changes proposed in this Pull Request:

  • Updates map keyword to maps in Map block. This will allow for both strings to return a result in the block selector.
  • Adds social keyword to Pinterest block.
  • Adds a variety of new keywords to some core blocks, hoping for better findability.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

See Quick Wins in paYJgx-qn-p2.

Testing instructions:

  • Run yarn build-extensions to compile these changes.
  • Open the Editor, then open the block picker and search for "social". Facebook, Twitter, Tumblr, Pinterest, and Instagram blocks should be part of the search results.
  • In your browser console, run wp.blocks.getBlockType('core-embed/crowdsignal') and check to see that the "survey" keyword was added.

Proposed changelog entry for your changes:

  • Enhanced block search results through additional keywords.

Changes and adds keywords to a few blocks that will hopefully be easier to find now.
@obenland obenland added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] Map [Block] Pinterest labels Feb 13, 2020
@obenland obenland requested review from a team February 13, 2020 00:02
@obenland obenland self-assigned this Feb 13, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello obenland! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38792-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Feb 13, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against b0b0317

marekhrabe
marekhrabe previously approved these changes Feb 13, 2020
Copy link
Contributor

@marekhrabe marekhrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left two comments but I wouldn't mind if this PR got in as is. Already a big improvement and we can (and will) continue making changes in this area further. I've also tested the wpcom diff and it matches described changes

extensions/blocks/map/settings.js Show resolved Hide resolved
extensions/shared/block-keywords.js Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 13, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 13, 2020
Just because `map` is part of `maps` in English, doesn't mean that that'll be the case in all languages.

Props @marekhrabe
@matticbot
Copy link
Contributor

obenland, Your synced wpcom patch D38792-code has been updated.

@obenland obenland requested a review from jeherve February 13, 2020 21:35
@obenland
Copy link
Member Author

@jeherve I'm not sure who's in charge of github-phab-bot but (1) that automation is pretty cool, unfortunately (2) it doesn't seem to sync over added files 😬

Thanks for your review, I think this is ready for another round.

We'll use core's update
@matticbot
Copy link
Contributor

obenland, Your synced wpcom patch D38792-code has been updated.

@jeherve
Copy link
Member

jeherve commented Feb 14, 2020

  1. that automation is pretty cool

It is :) The tool is part of Fusion, which helps us keep Jetpack and wpcom in sync.

unfortunately (2) it doesn't seem to sync over added files

Correct. That's something we have yet to implement. For now, that means that once this PR is merged here in Jetpack, you'll need to copy the file over to your sandbox manually, svn add it, and update the Fusion-generated diff so it includes that file (in practice that will mean something like:

arc diff --update D38792 xx \
xx \
xx

xx being all the unbuilt files you've modified / added. github-phab-bot will then come around and update your diff to add all built files to the diff for you.
Let me know if you need help with any of this!

Edit: and I now see you've removed the filter. Don't mind me :)

@jeherve jeherve removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 14, 2020
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 14, 2020
@obenland obenland merged commit bf52e73 into master Feb 14, 2020
@obenland obenland deleted the update/block-keywords branch February 14, 2020 19:45
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Map [Block] Pinterest [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajax: Improve block search results
5 participants