Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Hide backups update nudge for multisite #14660

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Settings: Hide backups update nudge for multisite #14660

merged 3 commits into from
Feb 13, 2020

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented Feb 13, 2020 •
edited by kraftbj
Loading

Partial fix for #14656

Related: #14657

Changes proposed in this Pull Request:

  • Hide Backups upgrade nudge in security settings page

Testing instructions:

  • Start with multisite (JN can help)
  • connect Jetpack and select the free plan
  • go to /wp-admin/admin.php?page=jetpack#/security and make sure that Backups update nudge is not there.
  • Repeat the above steps for singlesite where backups available.

Proposed changelog entry for your changes:

  • Settings: Hide Backups update nudge for multisite sites

@brbrr brbrr added [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu [Feature] Backup & Scan labels Feb 13, 2020
@brbrr brbrr requested a review from a team as a code owner February 13, 2020 03:51
@brbrr brbrr self-assigned this Feb 13, 2020
@jetpackbot
Copy link

jetpackbot commented Feb 13, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 000c729

@brbrr brbrr changed the title Settings Hide backups update nudge for multisite Settings: Hide backups update nudge for multisite Feb 13, 2020
@brbrr brbrr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Feb 13, 2020
@kraftbj kraftbj added this to the 8.3 milestone Feb 13, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 13, 2020
@kraftbj kraftbj merged commit 37ba493 into master Feb 13, 2020
@kraftbj kraftbj deleted the hide/settings-backups-multisite branch February 13, 2020 21:36
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@brbrr brbrr

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Backup & Scan
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@brbrr @jetpackbot @jeherve @kraftbj @matticbot