Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: add paid label next to block title when it requires a plan #14739

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Blocks: add paid label next to block title when it requires a plan #14739

merged 7 commits into from
Mar 4, 2020

Commits on Feb 19, 2020

  1. Blocks: add paid label next to block title when it requires a plan

    @jeherve
    jeherve committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    b2f471c View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Rename the plan checker func & add comments

    @WunderBart
    WunderBart committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    1135ebe View commit details
    Browse the repository at this point in the history

  2. Join block tags and make 'beta' translatable

    @WunderBart
    WunderBart committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    3126d2d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Using _x to translate 'paid' string to provide context for the transl… 

    …ation
    @jeryj
    jeryj committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    6ef33cd View commit details
    Browse the repository at this point in the history

  2. Use template literal for building block tags to make the code more re… 

    …adable.
    @jeryj
    jeryj committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2269416 View commit details
    Browse the repository at this point in the history

  3. Changed the object property from availableBlockTags.plan to available… 

    …BlockTags.paid

The availableBlockTags object has the property paid, and not plan. The check to add the (paid) label was looking for the availableBlockTags.plan property, which was undefined. I updated this to look for availableBlockTags.paid.
    @jeryj
    jeryj committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    0a325fb View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Refactors block title and block tags implementation to be into more i… 

    …solated build functions.

- Adds buildBlockTags( name, requiredPlan)
- Adds buildBlockTitle( blockTitle, blockTags )
- Builds the title in registerJetpackBlock with buildBlockTitle( settings.title, buildBlockTags( name, requiredPlan ) )
    @jeryj
    jeryj committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    25129a6 View commit details
    Browse the repository at this point in the history