-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Calendar block: Fix error message positioning #14833
Conversation
…valid embed code.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
@apeatling Hi Andy, I was reviewing this and confirmed the margin is added to the notice. However I'm showing that all the content is centered. Seeing this on both twentysixteen & twentytwenty and wanted to confirm there wasn't anything to be concerned about. |
@mdbitz I'm not seeing the centering with twentytwenty, but I do see some odd font usage. I'll dig in a bit and see what's up. I don't think it's related to my change. |
:nod: I see the centering when I use master as well. I'm going to approve this and bring it across into 8.3 as its unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified margin is applied to the notice.
…hen using an invalid embed code. (#14833)
Cherry Picked in : 7e42673 |
r203589-wpcom |
When providing an invalid embed link fix the error message positioning.
Fixes #14824
Before:
After:
Testing instructions:
Proposed changelog entry for your changes:
None