WooCommerce Analytics: make it available as module

[jeherve]

Changes proposed in this Pull Request:

WooCommerce Analytics was always enabled until now, and could not be disabled unless you were to hook into jetpack_tools_to_include.

This PR makes the feature a proper module.

• The module is automatically enabled so should be automatically enabled on plugin update, unless folks turned that off with a filter like jetpack_get_default_modules.
• It will only appear as available in the full module list (at wp-admin/admin.php?page=jetpack_modules)
• It will be greyed out there if you do not use WooCommerce, or use an old version of WooCommerce:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• p7Ldg5-ru-p2

Testing instructions:

• On a site that does not run WooCommerce, go to wp-admin/admin.php?page=jetpack_modules; you should see the module greyed out.
• Activate WooCommerce. You should see the module available and active.
• Follow the instructions in add woo analytics event props for block/shortcode use in cart/checkout #15127 to make sure the module still works.

Proposed changelog entry for your changes:

• N/A

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 31c98ee

[brbrr]

works for me. Although I wasn't able to get new parameters as explained in #15127

[haszari]

Tested and confirmed this is all working well:

• Woo analytics can be enabled and disabled.
• Woo analytics only sends events when it is enabled.
• Woo analytics is unavailable and disabled when Woo plugin is not active.

I noticed that woo analytics module was disabled by default – when active Jetpack is updated to the version with the module, or after Jetpack is freshly activated. Is this as expected – is my dev setup or some config on my end breaking this somehow?

[haszari]

Is this as expected – is my dev setup or some config on my end breaking this somehow?

Ah I see – to test activation by default, I'd need to simulate updating from 8.3 => 8.4, by changing the version number. Or, test the beta build which will be available soon :)

[psealock]

Thanks @jeherve this is looking great and testing well for me! I can toggle on/off and see the effect on requests for t.gif.

Activate WooCommerce. You should see the module available and active.

The module isn't active by default for me, I have to click "Activate" after re-activating WooCommerce.

On a site that does not run WooCommerce

I only de-activated instead of deleting or running on a site that never had Woo. Perhaps that is the reason?

[psealock]

Ok, I read previous comments here and p7Ldg5-ru-p2. Sounds good to me 🚢

[jeherve]

@brbrr I just pushed 31c98ee to ensure auto-activation happens properly when the version update happens. Do you think you could give this another review?

Thank you!

[brbrr]

LGTM 🚢