Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendly Block: Replace SubmitButton with new button block #15863

Merged
merged 19 commits into from
Jun 22, 2020

Commits on Jun 12, 2020

  1. Replace Calendly SubmitButton with shared button

    The new shared button offers a few extra features and an oportunity to make
    multiple components more consistent. As such, the SubmitButton in the Calendly
    block is being replaced.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    84de645 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b110bba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    749c874 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary deffinition of innerButtonBlock

    The example is style: 'inline', which is the actual widget embed, where the Button is not displayed. So, defining the innerBlocks here is unnecessary. We can just define it within the edit.js where it is used instead.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    0548c4f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6b888e4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d873832 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83eed66 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8ace2c8 View commit details
    Browse the repository at this point in the history
  9. Relocate calendly spinner

    Given the varying heights of the inline styled calendly blocks, its possible that the spinner is still visible after the widget loads. This will reposition it so it gets hidden.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    fa4238c View commit details
    Browse the repository at this point in the history
  10. Prevent full-width block triggering button popup

    Previously, on the frontend, clicking in the empty space beside the button would attempt to trigger the button's click.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    9ba5061 View commit details
    Browse the repository at this point in the history
  11. Fix inconsistent block id placement and event listener

    Previous fix to event listener solved deperecated markup clicks but created issue on migrated and new blocks.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    c280cb9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e1dcba6 View commit details
    Browse the repository at this point in the history
  13. Use new passthroughAttributes to update button URL

    Only the URL has been added to passthrough attributes as other properties that may set via embed code can be updated via the button's block settings.
    aaronrobertshaw committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    d0b2251 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    161520e View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Fix editor center alignment for button

    With the Gutenberg plugin v8.3.0 installed and active it creates slightly different markup so the preexisting styles no longer center align the button. This fixes that and improves frontend style.
    aaronrobertshaw committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f9c1196 View commit details
    Browse the repository at this point in the history
  2. Fix JETPACK__VERSION constant use

    Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
    aaronrobertshaw and jeherve authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b9bbee9 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    7e442cd View commit details
    Browse the repository at this point in the history
  2. Update block button url with embed params

    After switch to using the block button and passing through the url attribute, the embed params for background, text and primary color were lost. The original approach to parsing embed code strips the url back to basics and only adds the query string params when generating markup.
    
    This change simply replaces the base url with the one containing query string params as this had the least impact on existing approach.
    aaronrobertshaw committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8478cce View commit details
    Browse the repository at this point in the history
  3. Set button blocks default font color

    After the switch to the shared button block, the default color provided by the .wp-block wrapper element was lost this sets the same color.
    aaronrobertshaw committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f450dba View commit details
    Browse the repository at this point in the history