-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendly Block: Replace SubmitButton with new button block #15863
Calendly Block: Replace SubmitButton with new button block #15863
Commits on Jun 12, 2020
-
Replace Calendly SubmitButton with shared button
The new shared button offers a few extra features and an oportunity to make multiple components more consistent. As such, the SubmitButton in the Calendly block is being replaced.
Configuration menu - View commit details
-
Copy full SHA for 84de645 - Browse repository at this point
Copy the full SHA 84de645View commit details -
Configuration menu - View commit details
-
Copy full SHA for b110bba - Browse repository at this point
Copy the full SHA b110bbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 749c874 - Browse repository at this point
Copy the full SHA 749c874View commit details -
Remove unnecessary deffinition of innerButtonBlock
The example is style: 'inline', which is the actual widget embed, where the Button is not displayed. So, defining the innerBlocks here is unnecessary. We can just define it within the edit.js where it is used instead.
Configuration menu - View commit details
-
Copy full SHA for 0548c4f - Browse repository at this point
Copy the full SHA 0548c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b888e4 - Browse repository at this point
Copy the full SHA 6b888e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d873832 - Browse repository at this point
Copy the full SHA d873832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83eed66 - Browse repository at this point
Copy the full SHA 83eed66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ace2c8 - Browse repository at this point
Copy the full SHA 8ace2c8View commit details -
Given the varying heights of the inline styled calendly blocks, its possible that the spinner is still visible after the widget loads. This will reposition it so it gets hidden.
Configuration menu - View commit details
-
Copy full SHA for fa4238c - Browse repository at this point
Copy the full SHA fa4238cView commit details -
Prevent full-width block triggering button popup
Previously, on the frontend, clicking in the empty space beside the button would attempt to trigger the button's click.
Configuration menu - View commit details
-
Copy full SHA for 9ba5061 - Browse repository at this point
Copy the full SHA 9ba5061View commit details -
Fix inconsistent block id placement and event listener
Previous fix to event listener solved deperecated markup clicks but created issue on migrated and new blocks.
Configuration menu - View commit details
-
Copy full SHA for c280cb9 - Browse repository at this point
Copy the full SHA c280cb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1dcba6 - Browse repository at this point
Copy the full SHA e1dcba6View commit details -
Use new passthroughAttributes to update button URL
Only the URL has been added to passthrough attributes as other properties that may set via embed code can be updated via the button's block settings.
Configuration menu - View commit details
-
Copy full SHA for d0b2251 - Browse repository at this point
Copy the full SHA d0b2251View commit details -
Configuration menu - View commit details
-
Copy full SHA for 161520e - Browse repository at this point
Copy the full SHA 161520eView commit details
Commits on Jun 16, 2020
-
Fix editor center alignment for button
With the Gutenberg plugin v8.3.0 installed and active it creates slightly different markup so the preexisting styles no longer center align the button. This fixes that and improves frontend style.
Configuration menu - View commit details
-
Copy full SHA for f9c1196 - Browse repository at this point
Copy the full SHA f9c1196View commit details -
Fix JETPACK__VERSION constant use
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Configuration menu - View commit details
-
Copy full SHA for b9bbee9 - Browse repository at this point
Copy the full SHA b9bbee9View commit details
Commits on Jun 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7e442cd - Browse repository at this point
Copy the full SHA 7e442cdView commit details -
Update block button url with embed params
After switch to using the block button and passing through the url attribute, the embed params for background, text and primary color were lost. The original approach to parsing embed code strips the url back to basics and only adds the query string params when generating markup. This change simply replaces the base url with the one containing query string params as this had the least impact on existing approach.
Configuration menu - View commit details
-
Copy full SHA for 8478cce - Browse repository at this point
Copy the full SHA 8478cceView commit details -
Set button blocks default font color
After the switch to the shared button block, the default color provided by the .wp-block wrapper element was lost this sets the same color.
Configuration menu - View commit details
-
Copy full SHA for f450dba - Browse repository at this point
Copy the full SHA f450dbaView commit details