Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WooCommerce Anaylytics: PHPCS #16032

Merged
merged 6 commits into from
Jun 5, 2020
Merged

WooCommerce Anaylytics: PHPCS #16032

merged 6 commits into from
Jun 5, 2020

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jun 1, 2020

WPCS for the woocommerce-analytics module.
Fixes #10117
Closes #10496

Changes proposed in this Pull Request:

  • PHPCS

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Does this pull request change what data or activity we track or use?

  • No changes.

Testing instructions:

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added [Feature] WooCommerce Analytics [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jun 1, 2020
@kraftbj kraftbj self-assigned this Jun 1, 2020
@kraftbj kraftbj changed the title WooCommerce Anaylytics: PHCS WooCommerce Anaylytics: PHPCS Jun 1, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16032

Scheduled Jetpack release: June 2, 2020.
Scheduled code freeze: May 26, 2020

Generated by 🚫 dangerJS against 9461cd8

@jeherve jeherve added this to the 8.7 milestone Jun 2, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 2, 2020
@kraftbj kraftbj merged commit cfaf049 into master Jun 5, 2020
@kraftbj kraftbj deleted the wpcs/woo-analytics branch June 5, 2020 15:11
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
[Feature] WooCommerce Analytics [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.

WooCommerce Analytics: not referring to the static class property
5 participants
@kraftbj @jetpackbot @jeherve @matticbot @Rahmon