Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenburg blocks: use BlockIcon in MediaPlaceholder for Simple payments #16232

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Gutenburg blocks: use BlockIcon in MediaPlaceholder for Simple payments #16232

merged 2 commits into from
Jun 24, 2020

Conversation

fgiannar
Copy link
Contributor

@fgiannar fgiannar commented Jun 22, 2020 •
edited
Loading

Fixes ##11843

Since this PR has already addressed:

  • Tiled gallery
  • Slideshow

Changes proposed in this Pull Request:

  • Use BlockIcon component for custom icons in media-placeholders for Simple payments.

Testing instructions:

  • Build extensions yarn build-extensions
  • Insert Simple Payments block to a post
  • Ensure no visual differences in placeholder's icon placement/spacing/size

Before

before

After

Screenshot 2020-06-23 at 10 49 24 AM

Proposed changelog entry for your changes:

  • Gutenburg blocks: use BlockIcon in MediaPlaceholder for Simple payments

@fgiannar fgiannar added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Low Pay with Paypal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Jun 22, 2020
@fgiannar fgiannar self-assigned this Jun 22, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello fgiannar! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D45281-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Jun 22, 2020 •
edited
Loading

Warnings
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16232

Generated by 🚫 dangerJS against 2acbcfe

@jeherve jeherve added this to the 8.7 milestone Jun 22, 2020
@jeherve jeherve requested a review from simison June 22, 2020 14:45
jeherve
jeherve previously requested changes Jun 22, 2020
View reviewed changes
extensions/blocks/simple-payments/featured-media.js Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 22, 2020
@fgiannar fgiannar added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 23, 2020
leogermani
leogermani approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it looks the same after applied this branch

@leogermani leogermani dismissed jeherve’s stale review June 23, 2020 14:26

changes were applied

@leogermani leogermani added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 23, 2020
@fgiannar fgiannar merged commit ba6488a into master Jun 24, 2020
@fgiannar fgiannar deleted the update/gutenberg-blocks-blockicon-in-mediaplaceholder branch June 24, 2020 16:01
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 24, 2020
@jeherve
Copy link
Member

jeherve commented Jun 24, 2020

r209532-wpcom

@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@leogermani leogermani leogermani approved these changes

@simison simison Awaiting requested review from simison

Assignees

@fgiannar fgiannar

Labels
[Block] Pay With Paypal aka Simple Payments [Feature] Pay with PayPal aka Simple Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Low Touches WP.com Files
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
5 participants
@fgiannar @matticbot @jetpackbot @jeherve @leogermani