Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: update to latest stable of @wordpress/element #16478

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Build: update to latest stable of @wordpress/element #16478

merged 1 commit into from
Jul 14, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 14, 2020

Changes proposed in this Pull Request:

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

  • The build should complete with no errors, and you should notice no differences in the Jetpack dashboard.

Proposed changelog entry for your changes:

  • N/A

@jeherve
Build: update to latest stable of @wordpress/element
5fb60eb 
Updating this will allow us to start using things like `createInterpolateElement` in the React dashboard.
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal Build labels Jul 14, 2020
@jeherve jeherve added this to the 8.8 milestone Jul 14, 2020
@jeherve jeherve self-assigned this Jul 14, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D46343-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16478

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 5fb60eb

mdbitz
mdbitz approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@mdbitz mdbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Dashboard loads, Settings toggle and I'm able to connect users without issue.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jul 14, 2020
@jeherve jeherve merged commit 8babe85 into master Jul 14, 2020
@jeherve jeherve deleted the update/wordpress-element branch July 14, 2020 11:55
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 14, 2020
@jeherve
Copy link
Member Author

jeherve commented Jul 14, 2020

r210413-wpcom

This was referenced Jul 15, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbitz mdbitz mdbitz approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu Build [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal Touches WP.com Files
Projects
None yet
Milestone
8.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @mdbitz