Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: update to latest version of eslint-plugin-wpcalypso #16566

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Linting: update to latest version of eslint-plugin-wpcalypso #16566

merged 1 commit into from
Jul 27, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 24, 2020

Changes proposed in this Pull Request:

It should help us avoid having to skip the wpcalypso/import-docblock rule like here:
#16545 (comment)

More info about the update:
Automattic/wp-calypso#44388

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

  • Do the tests pass?

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Jul 24, 2020
@jeherve jeherve added this to the 8.8 milestone Jul 24, 2020
@jeherve jeherve requested a review from mmtr July 24, 2020 08:52
@jeherve jeherve self-assigned this Jul 24, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D46850-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Jul 24, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16566

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 159a95a

@jeherve
Linting: update to the latest version of eslint-plugin-wpcalypso
159a95a 
It should help us avoid having to skip the wpcalypso/import-docblock rule like here:
#16545 (comment)

More info about the update:
Automattic/wp-calypso#44388
@jeherve jeherve force-pushed the update/eslint-calypso branch from 595b2f9 to 159a95a Compare July 24, 2020 17:17
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 27, 2020
@jeherve jeherve changed the title Linting: update to the latest version of eslint-plugin-wpcalypso Linting: update to latest version of eslint-plugin-wpcalypso Jul 27, 2020
@jeherve jeherve merged commit c2ae4a5 into master Jul 27, 2020
@jeherve jeherve deleted the update/eslint-calypso branch July 27, 2020 07:19
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 27, 2020
@jeherve jeherve mentioned this pull request Jul 27, 2020
Closed
1 task
@jeherve jeherve mentioned this pull request Jul 27, 2020
Merged
@jeherve
Copy link
Member Author

jeherve commented Jul 27, 2020

r211010-wpcom

@mmtr mmtr mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@mmtr mmtr Awaiting requested review from mmtr

Assignees

@jeherve jeherve

Labels
General Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @kraftbj