Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: introduce new package for block management #17100

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Blocks: introduce new package for block management #17100

merged 1 commit into from
Sep 8, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 8, 2020

See #17099

Changes proposed in this Pull Request:

  • This PR introduces the scaffolding for a new package, that both the Jetpack plugin and standalone blocks could rely on from now on.

Jetpack product discussion

  • p9dueE-1BH-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Not much to test yet since the package is not used for anything just yet.

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Feature Request [Pri] Normal [Focus] Jetpack DNA [Package] Blocks labels Sep 8, 2020
@jeherve jeherve added this to the 9.0 milestone Sep 8, 2020
@jeherve jeherve self-assigned this Sep 8, 2020
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 8, 2020
@jeherve jeherve mentioned this pull request Sep 8, 2020
Closed
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17100

Scheduled Jetpack release: October 6, 2020.
Scheduled code freeze: September 29, 2020

Generated by 🚫 dangerJS against 56a4af8

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 8, 2020
@jeherve jeherve merged commit 73144ee into master Sep 8, 2020
@jeherve jeherve deleted the add/blocks-package branch September 8, 2020 14:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 8, 2020
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@jeherve @pereirinha
[not verified] Blocks: introduce new package for block management (#1…
2900b4f 
…7100)

See #17099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Focus] Jetpack DNA [Package] Blocks [Pri] Normal [Status] Needs Package Release This PR made changes to a package. Let's update that package now. [Type] Feature Request
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @kraftbj @matticbot