-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent adding adding AMP hooks for Infinite Scroll on legacy AMP post templates #17175
Prevent adding adding AMP hooks for Infinite Scroll on legacy AMP post templates #17175
Conversation
Scheduled Jetpack release: October 6, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17175 Thank you for the great PR description! When this PR is ready for review, please apply the |
Thanks for the report! @pereirinha Do you think you could take a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well on my end.
Internal reference: D49673-code -- r213721-wpcom |
@jeherve I just found that this also causes a problem with Web Stories. It is causing the |
Done. When viewing a singular Web Story: Before…
</amp-story><amp-next-page max-pages="0">
<script type="application/json">
[
{"title":"","url":"","image":""} ]
</script>
<div separator>
<hr class="post-separator styled-separator is-style-wide section-inner" aria-hidden="true">
</div>
<div recommendation-box class="recommendation-box">
<template type="amp-mustache">
{{#pages}}
<div id="infinite-handle" class="read-more-button-wrap">
<span>
<a href="{{url}}" class="more-link" rel="amphtml">
<span class="faux-button">
Older posts </span>
</a>
</span>
</div>
{{/pages}}
</template>
</div>
<div footer>
</div>
</amp-next-page>
</body></html> After…
</amp-story></body></html> cc @swissspidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still tests well for me, nice work! 👍
r213776-wpcom |
Thank you @westonruter and @jeherve. |
Fixes a regression introduced in #16048. See #16048 (comment):
The validation errors currently occurring on AMP pages on WordPress.com using the Reader mode template when infinite scroll is enabled:
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
amp-next-page
(on AMP plugin v1.5+).Proposed changelog entry for your changes: