Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add info about textdomains to the package documentation #18070

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

kbrown9
Copy link
Member

@kbrown9 kbrown9 commented Dec 11, 2020

Changes proposed in this Pull Request:

  • Add info about textdomains to the package documentation.

Jetpack product discussion

We've been investigating providing a way for consumer plugins to change the textdomains in the packages. I found a couple of PRs from last year: #12525 and #12471. From the conversations in those PRs, in looks like the final decision was to let consumer plugins provide their own solution for updating textdomains in the packages.

I think this is the best approach. Consumer plugins should choose the tool and process that works best for that plugin, and there's no need for Jetpack to provide a tool for this. Instead, we should update the documentation so that consumer plugins understand that updating the textdomain is their responsibility. We can also provide links to a few tools that may be helpful, which I've done in this PR.

Does this pull request change what data or activity we track or use?

  • no

Testing instructions:

  • No testing is required. Just verify that the documentation update is correct, clear, and doesn't have any typos.

Proposed changelog entry for your changes:

  • n/a

@kbrown9 kbrown9 added Docs [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Low [Focus] Jetpack DNA labels Dec 11, 2020
@kbrown9 kbrown9 requested a review from zinigor December 11, 2020 18:43
@kbrown9 kbrown9 self-assigned this Dec 11, 2020
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Dec 11, 2020
@jetpackbot
Copy link

jetpackbot commented Dec 11, 2020

Scheduled Jetpack release: January 12, 2021.
Scheduled code freeze: January 4, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against e947c75

@kbrown9 kbrown9 added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2020
@kbrown9 kbrown9 force-pushed the update/package_docs_textdomain branch from c93aad6 to e947c75 Compare December 29, 2020 18:19
@kbrown9 kbrown9 added this to the 9.3 milestone Dec 29, 2020
@kbrown9 kbrown9 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Dec 29, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 4, 2021
@kbrown9 kbrown9 merged commit 81587b4 into master Jan 4, 2021
@kbrown9 kbrown9 deleted the update/package_docs_textdomain branch January 4, 2021 15:27
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs [Focus] i18n Internationalization / i18n, adaptation to different languages [Focus] Jetpack DNA [Pri] Low [Status] Needs Package Release This PR made changes to a package. Let's update that package now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants