Connection UI: Building the Framework

[sergeymitr]

Changes proposed in this Pull Request:

• The new package
• JS building configuration
• Handy yarn commands
• The WP admin menu link

The new commands (run from packages/connection-ui/ directory):

• yarn build
• yarn watch

The Jetpack command yarn build-packages was also edited to also build the Connection UI package.

Jetpack product discussion

p9dueE-1vM-p2
Related to #18182

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

1. Go to packages/connection-ui and run yarn install to install the required modules.
2. Run yarn build, confirm no errors come up.
3. Go to WP admin area, "Tools -> Connection Manager", you should see the "Connection Manager" header. That means the build was successful.
4. Run yarn watch.
5. Open the file packages/connection-ui/_inc/admin.jsx and change the Connection Manager text to something else.
6. Wait a few seconds, reload the "Tools -> Connection Manager" page, make sure the changed text appears.
7. Stop the watching process (Ctrl+C).
8. Revert the file packages/connection-ui/_inc/admin.jsx to its original state.
9. Go to the Jetpack root directory and run yarn build-packages. Confirm that it shows no errors.
10. Once finished, reload the "Tools -> Connection Manager" page again. Make sure it reflects the latest changes.

The PR uses a deprecated function registerStore() of the @wordpress/data component.
Unfortunately, we can't replace it with createReduxStore() and register() right now, because they are not included into the latest Wordpress build of @wordpress/data.

Proposed changelog entry for your changes:

n/a

[test-case-reminder]

Here are some suggested test cases for this PR.

Connection

• In-place connection with free plan
• In-place connection with paid plan
• In-place connection with product purchase
• Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
• Disconnect/reconnect connection
• Secondary user connection
• Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

• WooCommerce Payments
• Jetpack Boost
• Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello sergeymitr! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D55178-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[jetpackbot]

Scheduled Jetpack release: February 16, 2021.
Scheduled code freeze: February 8, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against dc20e24

[kraftbj]

As an FYI, later this week, GC will be merging our repo reorg patch that, will among other things, allow for individual projects--like this new package--to build and commit to their mirror repo a JS-built version.

In other words, Composer clients can consume the package and get the built, ready to use JS after we merge and set things up for this package.

[zinigor]

This is a great start, thank you! We're moving in the right direction, I have left some comments in the code, please take a look.

[sergeymitr]

Rebased to resolve a conflict with the master branch.

[zinigor]

One minor change, and I think this is ready to be shipped. Thanks for working on this!

[jeherve]

I think we would need a .gitattributes in here to specify what we don't want to ship with the production package.

[zinigor]

Let's get this party started!

[anomiex]

Adding approval based on the previous version receiving approvals from others. Haven't reviewed myself.

Completed