-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection UI: Building the Framework #18303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME
to true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
Verify that the changes are compatible with the plugins that use the connection package.
- WooCommerce Payments
- Jetpack Boost
- Previous versions of Jetpack
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
Caution: This PR has changes that must be merged to WordPress.com |
Scheduled Jetpack release: February 16, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
179f413
to
33feb1c
Compare
As an FYI, later this week, GC will be merging our repo reorg patch that, will among other things, allow for individual projects--like this new package--to build and commit to their mirror repo a JS-built version. In other words, Composer clients can consume the package and get the built, ready to use JS after we merge and set things up for this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, thank you! We're moving in the right direction, I have left some comments in the code, please take a look.
4f95923
to
8cf363b
Compare
8cf363b
to
ad0bc7a
Compare
Rebased to resolve a conflict with the |
859b493
to
290d8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, and I think this is ready to be shipped. Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would need a .gitattributes
in here to specify what we don't want to ship with the production package.
a114b3e
to
003799c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this party started!
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding approval based on the previous version receiving approvals from others. Haven't reviewed myself.
Changes proposed in this Pull Request:
The new commands (run from
packages/connection-ui/
directory):yarn build
yarn watch
The Jetpack command
yarn build-packages
was also edited to also build the Connection UI package.Jetpack product discussion
p9dueE-1vM-p2
Related to #18182
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
packages/connection-ui
and runyarn install
to install the required modules.yarn build
, confirm no errors come up.yarn watch
.packages/connection-ui/_inc/admin.jsx
and change theConnection Manager
text to something else.packages/connection-ui/_inc/admin.jsx
to its original state.yarn build-packages
. Confirm that it shows no errors.The PR uses a deprecated function
registerStore()
of the@wordpress/data
component.Unfortunately, we can't replace it with
createReduxStore()
andregister()
right now, because they are not included into the latest Wordpress build of@wordpress/data
.Proposed changelog entry for your changes:
n/a