-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override masterbar to show quick links on Atomic sites #18791
Conversation
Scheduled Jetpack release: March 2, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
Caution: This PR has changes that must be merged to WordPress.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty close, @tjcafferkey! I do see the full masterbar now, but I noted there is a weird orange box (probably related to the orange Debug menu item on the masterbar) and the avatar looks like it's misplaced.
Is that something that can be fixed?
Hmm I encountered that avatar issue myself and thought I had fixed it. I'll continue to take a look at this thanks @mmtr! 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that last minor! LGTM 🚢 !
I have also applied the patch in wpcom and inspected that we haven't broken something. |
I have restarted the failing wpcom tests Edit: They have now passed ✅! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me.
Deployed to WPCOM in r221126-wpcom |
Fixes Automattic/wp-calypso#49793
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Repeat steps on a non-A8C account to ensure this works as expected for non-nav unified users.
Proposed changelog entry for your changes: