Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: separate node project #18806

Merged
merged 9 commits into from
Feb 16, 2021
Merged

E2E tests: separate node project #18806

merged 9 commits into from
Feb 16, 2021

Conversation

adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Feb 12, 2021 •
edited
Loading

Extract E2E tests as a separate Node project from Jetpack plugin project.
E2E tests have their own package.json.
p9dueE-2sL-p2

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

E2E tests should pass.

Proposed changelog entry for your changes:

n/a

@adimoldovan adimoldovan self-assigned this Feb 12, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello adimoldovan! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D56986-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 12, 2021
@jetpackbot
Copy link

jetpackbot commented Feb 12, 2021 •
edited
Loading

Scheduled Jetpack release: March 2, 2021.
Scheduled code freeze: February 22, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 3e87c6b

@adimoldovan adimoldovan removed the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 12, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 12, 2021
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 12, 2021
@adimoldovan adimoldovan added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Feb 12, 2021
@brbrr
Copy link
Contributor

brbrr commented Feb 15, 2021

There are at least few dependencies that could be removed from Jetpack's package.json

brbrr
brbrr suggested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in a comment, there still e2e-specific packages that we probably can remove from Jetpack's package.json. such as Winston & e2e-utils

brbrr
brbrr suggested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like config also could be removed.

brbrr
brbrr approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge once tests are green

@adimoldovan adimoldovan merged commit fb318a7 into master Feb 16, 2021
@adimoldovan adimoldovan deleted the e2e-separate-node-project branch February 16, 2021 11:32
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 16, 2021
@github-actions github-actions bot added this to the 9.5 milestone Feb 16, 2021
@brbrr
Copy link
Contributor

brbrr commented Feb 16, 2021

r221115-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

Assignees

@adimoldovan adimoldovan

Labels
Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.
5 participants
@adimoldovan @matticbot @jetpackbot @brbrr @jeherve