-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests: separate node project #18806
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Scheduled Jetpack release: March 2, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
There are at least few dependencies that could be removed from Jetpack's package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in a comment, there still e2e-specific packages that we probably can remove from Jetpack's package.json. such as Winston & e2e-utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like config
also could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge once tests are green
r221115-wpcom |
Extract E2E tests as a separate Node project from Jetpack plugin project.
E2E tests have their own package.json.
p9dueE-2sL-p2
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
E2E tests should pass.
Proposed changelog entry for your changes:
n/a