Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor: Do not open monitor notification preferences in new tab #18914

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

ebinnion
Copy link
Contributor

Changes proposed in this Pull Request:

  • Removes target property so that downtime monitoring notification settings opens in same tab

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Checkout patch
  • On a connected Jetpack site, go to Security tab
  • Click "Configure your notification settings" card and verify that the settings tab does not open in new page

Proposed changelog entry for your changes:

  • Opens downtime monitoring notification settings in same tab

@ebinnion ebinnion added [Feature] Monitor [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Feb 24, 2021
@ebinnion ebinnion self-assigned this Feb 24, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Include a changelog entry for any meaningful change.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: March 2, 2021.
  • Scheduled code freeze: February 22, 2021

@ebinnion ebinnion added this to the 9.5 milestone Feb 24, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 24, 2021
@jeherve jeherve merged commit 02b09b7 into master Feb 24, 2021
@jeherve jeherve deleted the update/for-nav-unification-bits branch February 24, 2021 09:17
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 24, 2021
jeherve pushed a commit that referenced this pull request Feb 24, 2021
@jeherve
Copy link
Member

jeherve commented Feb 24, 2021

Cherry-picked to jetpack/branch-9.5 in 17620cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Monitor [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants