Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup: bring back the connection screen image #20829

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

sergeymitr
Copy link
Contributor

Updating Webpack (#20789) changed the asset loading behavior, and the connection screen image disappeared:
Screen Shot 2021-08-25 at 3 04 00 PM

This PR brings it back by reintroducing the asset base URL we previously didn't need.

Changes proposed in this Pull Request:

  • Reintroduce the asset base URL.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Disconnect Jetpack.
  2. Go to the Backup plugin, and confirm that there's an image on the connection screen:

Screen Shot 2021-08-25 at 3 13 13 PM

@sergeymitr sergeymitr added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 25, 2021
@sergeymitr sergeymitr added this to the backup/0.3.0 milestone Aug 25, 2021
@sergeymitr sergeymitr requested a review from samiff August 25, 2021 19:14
@sergeymitr sergeymitr self-assigned this Aug 25, 2021
@github-actions github-actions bot added the [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. label Aug 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Backup plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me, thanks for fixing this 👍

@sergeymitr sergeymitr merged commit 728dde5 into master Aug 25, 2021
@sergeymitr sergeymitr deleted the fix/backup-connect-image branch August 25, 2021 21:15
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants