Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress Block: New Icon for Edit Button #20916

Merged
merged 3 commits into from
Sep 2, 2021
Merged

VideoPress Block: New Icon for Edit Button #20916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d81db5b
Replace the default edit icon with the new one from the gutenberg ico…
roundhill Sep 1, 2021
eef2120
Adding changelog.
roundhill Sep 1, 2021
8c1a5b5
Updating to use `@wordpress/icons` lib and keep icon 24px.
roundhill Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-videopress-block-edit-icon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: enhancement

Updated the edit icon design in the VideoPress block toolbar.
3 changes: 2 additions & 1 deletion projects/plugins/jetpack/extensions/blocks/videopress/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
} from '@wordpress/block-editor';
import { Component, createRef, Fragment } from '@wordpress/element';
import { __, _x, sprintf } from '@wordpress/i18n';
import { Icon, pencil } from '@wordpress/icons';
import classnames from 'classnames';
import { get, indexOf } from 'lodash';

Expand Down Expand Up @@ -276,7 +277,7 @@ const VideoPressEdit = CoreVideoEdit =>
className="components-icon-button components-toolbar__control"
label={ __( 'Edit video', 'jetpack' ) }
onClick={ this.switchToEditing }
icon="edit"
icon={ <Icon icon={ pencil } /> }
/>
</ToolbarGroup>
</BlockControls>
Expand Down