-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Tiled Gallery Block: save
functionality
#21481
Jetpack Tiled Gallery Block: save
functionality
#21481
Conversation
…ks on load if they weren't already in store.
…eed to find root cause.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
…. Fixing some lint warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it's working well. I didn't see any issues after three attempts.
If we find any issues with this workaround we can of course fix them in a separate PR.
Thanks for finding this solution @illusaen!
From the "Could not cleanly apply this PR to synced wpcom files" message under CI checks, it looks like there was an issue syncing to WP.com. I've ran into a similar error and was told it's safe to ignore (and is likely due to unrelated issue). If syncing had worked, we were going to mark the sync "abandoned" since we're not merging to |
Exactly. Since you're merging into a feature branch, this can be ignored for now. |
* [not verified] WIP implementation of save. * [not verified] WIP: Got block attributes to show up in serialization * [not verified] Make columnWidths nested array * [not verified] WIP: Now converts serialized HTML images to inner blocks on load if they weren't already in store. * [not verified] WIP load from save. Hacked in stuff to make it work. Need to find root cause. * Adding Platform checks to ensure that mobile changes don't affect web. Fixing some lint warnings. Co-authored-by: Wendy Chen <wendy.chen@automattic.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Adding workaround to allow for loading of serialized HTML into the mobile editor. Currently using the workaround to unblock the rest of the block functionality that still needs to be done; will revisit in the future. One known bug is that loading a 1-column HTML still shows "Problem Displaying Block".
See issues:
Changes proposed in this Pull Request:
Allows us to load serialized HTML for the mobile app so that the saved Tiled Gallery Block shows up on the editor.
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
Screenshots:
screen-20211020-153558.mp4