Add Licensing JS Package #21730

cbauerman · 2021-11-12T20:06:34Z

Changes proposed in this Pull Request:

Add new Licensing JS Package to power license activation flow in Plugins

Jetpack product discussion

p1HpG7-cSg-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Package is not connected to any plugin in this PR
- Follow-up PRs will contain more detailed instructions for testing UX.
Verify tests pass cd projects/js-packages/licensing/ && pnpm test

matticbot · 2021-11-12T20:06:41Z

Caution: This PR has changes that must be merged to WordPress.com
Hello cbauerman! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70048-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

.gitignore

github-actions · 2021-11-12T20:07:38Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

projects/js-packages/licensing/components/activation-screen-controls/style.scss

rcanepa · 2021-11-12T23:31:33Z

projects/js-packages/licensing/components/activation-screen-illustration/index.jsx

+			<img className="jp-license-activation-screen-illustration__img" src={ imageUrl } alt="" />
+			{ showSupportLink && (
+				<p className="jp-license-activation-screen-illustration__support-link">
+					{ createInterpolateElement( __( 'Do you need help? <a>Contact us.</a>', 'jetpack' ), {


Leaving a note here just to remember that we will need to add a link here.

projects/js-packages/licensing/components/activation-screen-success-info/style.scss

rcanepa

LGTM.

Code changes look fine and clearly establish the basis for the rest of the pieces of the UI that will come later in follow-up PRs. I have to say also that already tested most of these changes when they were part of a previous PR (closed in favor of this one).

Awesome work, Caleb!

jeherve

I gave this a first look. Thanks for adding the tests, that makes things a lot easier! I had a few remarks and questions, see below.

jeherve · 2021-11-15T13:24:20Z

projects/js-packages/licensing/components/activation-screen-controls/error-gridicon.jsx

+ */
+import React from 'react';
+
+const ErrorGridicon = () => {


Would it be an option to import the icon from @wordpress/icons instead?

warning from @wordpress/icons ( the bottom icon ) seems like an acceptable substitute to the original ( the top icon )

projects/js-packages/licensing/components/activation-screen-controls/index.jsx

projects/js-packages/licensing/components/activation-screen-controls/style.scss

...licensing/components/activation-screen-success-info/product-details/jetpack-backup-daily.jsx

...censing/components/activation-screen-success-info/product-details/jetpack-security-daily.jsx

projects/js-packages/licensing/index.jsx

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>

jeherve

This looks good to me. Let's merge this! 🚢 ⭐

github-actions · 2021-11-16T12:04:15Z

Great news! One last step: head over to your WordPress.com diff, D70048-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

anomiex · 2021-11-17T21:11:05Z

r235224-wpcom

cbauerman added the [Status] Needs Team Review label Nov 12, 2021

cbauerman self-assigned this Nov 12, 2021

matticbot added Touches WP.com Files labels Nov 12, 2021

cbauerman requested a review from a team November 12, 2021 20:06

cbauerman added this to the jetpack/10.4 milestone Nov 12, 2021

cbauerman commented Nov 12, 2021

View reviewed changes

.gitignore Show resolved Hide resolved

github-actions bot added [JS Package] Licensing RNA labels Nov 12, 2021

rcanepa reviewed Nov 12, 2021

View reviewed changes

projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated Show resolved Hide resolved

rcanepa reviewed Nov 12, 2021

View reviewed changes

projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated Show resolved Hide resolved

rcanepa reviewed Nov 12, 2021

View reviewed changes

cbauerman force-pushed the add/license-flow-js-package branch from 5994064 to abb45e0 Compare November 12, 2021 23:34

rcanepa reviewed Nov 12, 2021

View reviewed changes

projects/js-packages/licensing/components/activation-screen-success-info/style.scss Outdated Show resolved Hide resolved

rcanepa previously approved these changes Nov 12, 2021

View reviewed changes

cbauerman added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Nov 12, 2021

cbauerman enabled auto-merge (squash) November 13, 2021 02:29

jeherve reviewed Nov 15, 2021

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 15, 2021

cbauerman dismissed rcanepa’s stale review via c3b83be November 15, 2021 16:40

cbauerman disabled auto-merge November 15, 2021 18:45

cbauerman enabled auto-merge (squash) November 15, 2021 18:46

cbauerman added 4 commits November 15, 2021 10:52

Import new package from previouscommit

dd4e3d4

Add basic render test

539106f

add missing package changes

39ae12a

Add additional test to SuccessInfo component

b666c55

cbauerman and others added 16 commits November 15, 2021 10:52

fixup tests, component propTypes

7cc199f

reformat package files

32c0589

Restore license error display & test.

09a7262

reformat files

c3c8d91

Add changlogger

eb60782

remove old changelogs

4f26419

use state functions to keep eslint happy

d17783c

use var for gray color

b018ea2

remove Jetpack Logo color

97d3856

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>

Add all JP Greens

84ad360

remove JP Logo color

27c3b35

Update colors to use vars

43eba4c

remove license from package index

66dc3cb

include emoji in translated string

7977f22

repalce gridicon with wordpress/icon

1414203

eslint fixup

b9f7eef

cbauerman force-pushed the add/license-flow-js-package branch from 336e730 to b9f7eef Compare November 15, 2021 18:53

cbauerman added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 15, 2021

jeherve approved these changes Nov 16, 2021

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 16, 2021

cbauerman merged commit e9f9498 into master Nov 16, 2021

cbauerman deleted the add/license-flow-js-package branch November 16, 2021 12:03

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 16, 2021

rcanepa mentioned this pull request Nov 16, 2021

Update Licensing JS Package to make it support all Jetpack products #21770

Merged

coder-karen mentioned this pull request Dec 20, 2022

Removing box-sizing:border-box from Base Styles #28024

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Licensing JS Package #21730

Add Licensing JS Package #21730

cbauerman commented Nov 12, 2021

matticbot commented Nov 12, 2021

github-actions bot commented Nov 12, 2021 •

edited

Loading

rcanepa Nov 12, 2021

rcanepa left a comment

jeherve left a comment

jeherve Nov 15, 2021

cbauerman Nov 15, 2021

jeherve left a comment

github-actions bot commented Nov 16, 2021

anomiex commented Nov 17, 2021

Add Licensing JS Package #21730

Add Licensing JS Package #21730

Conversation

cbauerman commented Nov 12, 2021

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

matticbot commented Nov 12, 2021

github-actions bot commented Nov 12, 2021 • edited Loading

rcanepa Nov 12, 2021

Choose a reason for hiding this comment

rcanepa left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

jeherve Nov 15, 2021

Choose a reason for hiding this comment

cbauerman Nov 15, 2021

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 16, 2021

anomiex commented Nov 17, 2021

github-actions bot commented Nov 12, 2021 •

edited

Loading