-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Licensing JS Package #21730
Add Licensing JS Package #21730
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
projects/js-packages/licensing/components/activation-screen-controls/style.scss
Outdated
Show resolved
Hide resolved
projects/js-packages/licensing/components/activation-screen-controls/style.scss
Outdated
Show resolved
Hide resolved
<img className="jp-license-activation-screen-illustration__img" src={ imageUrl } alt="" /> | ||
{ showSupportLink && ( | ||
<p className="jp-license-activation-screen-illustration__support-link"> | ||
{ createInterpolateElement( __( 'Do you need help? <a>Contact us.</a>', 'jetpack' ), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a note here just to remember that we will need to add a link here.
5994064
to
abb45e0
Compare
projects/js-packages/licensing/components/activation-screen-success-info/style.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Code changes look fine and clearly establish the basis for the rest of the pieces of the UI that will come later in follow-up PRs. I have to say also that already tested most of these changes when they were part of a previous PR (closed in favor of this one).
Awesome work, Caleb!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a first look. Thanks for adding the tests, that makes things a lot easier! I had a few remarks and questions, see below.
*/ | ||
import React from 'react'; | ||
|
||
const ErrorGridicon = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be an option to import the icon from @wordpress/icons
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projects/js-packages/licensing/components/activation-screen-controls/index.jsx
Outdated
Show resolved
Hide resolved
projects/js-packages/licensing/components/activation-screen-controls/style.scss
Outdated
Show resolved
Hide resolved
projects/js-packages/licensing/components/activation-screen-controls/style.scss
Outdated
Show resolved
Hide resolved
...licensing/components/activation-screen-success-info/product-details/jetpack-backup-daily.jsx
Outdated
Show resolved
Hide resolved
...censing/components/activation-screen-success-info/product-details/jetpack-security-daily.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
336e730
to
b9f7eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Let's merge this! 🚢 ⭐
Great news! One last step: head over to your WordPress.com diff, D70048-code, and commit it. Thank you! |
r235224-wpcom |
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
cd projects/js-packages/licensing/ && pnpm test