Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-config-target-es: Configure mirror repo #21731

Merged
merged 1 commit into from
Nov 15, 2021
Merged

eslint-config-target-es: Configure mirror repo #21731

merged 1 commit into from
Nov 15, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 12, 2021

Changes proposed in this Pull Request:

Now that this has some testing in the monorepo, let's get ready to
release it.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

@anomiex
eslint-config-target-es: Configure mirror repo
864c1e3 
Now that this has some testing in the monorepo, let's get ready to
release it.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Nov 12, 2021
@anomiex anomiex self-assigned this Nov 12, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70049-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 15, 2021
@anomiex anomiex merged commit 7c9f6f2 into master Nov 15, 2021
@anomiex anomiex deleted the add/mirror-for-eslint-config-target-es branch November 15, 2021 17:18
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 15, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D70049-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Nov 15, 2021

r235063-wpcom

davidlonjon added a commit that referenced this pull request Nov 16, 2021
@davidlonjon
Merge branch 'master' into fix/boost-site-speed-home-url
7ebee7e 
* master: (22 commits)
  VideoPress: reload block on rating change (#21653)
  Assets: Changelog for package version 1.12.0 (#21744)
  assets: Add `wp_register_script` wrapper (and then use it everywhere) (#21689)
  eslint-config-target-es: Configure mirror repo (#21731)
  Use monorepo `validate-es` script to validate Webpack builds (#21729)
  Backup: Replace daily backup references/upsell links with new real-time products (#21715)
  Likes: reimplement non-admin portions without jQuery (#21726)
  Autoloader: Not activated autoload queue is false (#21517)
  Sync: add a new method, do_only_first_initial_sync (#21676)
  webpack-config: Configure minifier to preserve translator comments (#21667)
  webpack-config: Use `@automattic/babel-plugin-preserve-i18n` (#21700)
  Create eslint-config-target-es JS package (#21660)
  webpack-config: Fork calypso-build's mini-css-with-rtl plugin (#21595)
  Allow /sites/${site}/external-media/copy/pexels to insert post meta data  (#21659)
  jetpack: Don't set Webpack's `output.pathinfo` in production builds (#21727)
  Boost: Implement support for loading stylesheets when JavaScript is disabled in the context Critical CSS being enabled (#21713)
  RNA: export the Connection store (#21388)
  Display notice when user has unactivated product license keys (#21474)
  Gardening: ensure it can use Composer (#21712)
  Nav Unification: Display the stats sparkline on WP Admin for Atomic sites (#21655)
  ...
davidlonjon added a commit that referenced this pull request Nov 16, 2021
@davidlonjon
Merge branch 'master' into fix/boost-e2e-test-speed-score-assertion
3cd0c90 
* master:
  VideoPress: reload block on rating change (#21653)
  Assets: Changelog for package version 1.12.0 (#21744)
  assets: Add `wp_register_script` wrapper (and then use it everywhere) (#21689)
  eslint-config-target-es: Configure mirror repo (#21731)
  Use monorepo `validate-es` script to validate Webpack builds (#21729)
  Backup: Replace daily backup references/upsell links with new real-time products (#21715)
  Likes: reimplement non-admin portions without jQuery (#21726)
  Autoloader: Not activated autoload queue is false (#21517)
  Sync: add a new method, do_only_first_initial_sync (#21676)
  webpack-config: Configure minifier to preserve translator comments (#21667)
  webpack-config: Use `@automattic/babel-plugin-preserve-i18n` (#21700)
  Create eslint-config-target-es JS package (#21660)
  webpack-config: Fork calypso-build's mini-css-with-rtl plugin (#21595)
  Allow /sites/${site}/external-media/copy/pexels to insert post meta data  (#21659)
  jetpack: Don't set Webpack's `output.pathinfo` in production builds (#21727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@anomiex anomiex

Labels
[JS Package] Eslint Config Target Es [Pri] Normal RNA Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anomiex @matticbot @jeherve