Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: refactor Critical CSS: Part 1 #22163
Boost: refactor Critical CSS: Part 1 #22163
Changes from 119 commits
4df09b6
52c8893
51bb0c9
b9d596c
69c188c
9a93e71
9a2bf24
3cd1b51
64cbf72
910c975
b2be2b9
2ee198c
29ce1d2
c01f6c6
6ce9cdd
1849901
48a9159
5c916e2
8f823d4
dfa4930
71b7e0f
f0fec8c
831d997
2af3a56
12b2622
12dbf1b
3ce3ea2
60451d4
8dc42b5
5fc4d5e
6317dd3
cf007d5
cd48f94
05c1b5d
c4986b4
9256e66
c7d1281
25ed0c7
792f198
fbd2399
252a12b
c29bafe
fffddcc
152be97
968dcd5
8ebde19
4648ee2
a978121
e0c2cdb
4ffcc27
62c0367
89ff0db
28be845
976f318
fb16f9f
d2e693e
1843cc6
8d1bef5
ab8d901
0354259
dcd871e
1f59019
7b092d3
6fe31b6
bc59b62
3692988
7d2565d
31cc4a7
f51a6b1
0fd1d87
70c6803
73b3615
060f501
2d52c89
ad909d9
35a0ee1
08f9215
f619172
34002cc
5287f9b
a05036e
6b3f987
0174f65
6f2be9b
739b4bc
cf70c71
a84b5f5
aff3037
46b7423
1947431
d5ae9d7
8038970
9cf4f19
7b2a9f9
aa10845
de0f519
4b6b4a6
8854abd
38960a4
a8cd102
03d69c9
489c56a
fe0c0e1
6ec59cb
09bd4d8
c262e9f
c398ccb
65283da
6367679
4aaa81f
1352b1d
9226329
c7c69b2
967ce52
2a28b05
1f32532
507e4f0
b7401e5
8893c9c
970f6e3
ce453af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😲 Is THAT what a constructor does?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
Optimization
a synonym for Module?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimization is a feature, but a feature doesn't necessarily mean optimization.
This came out with a brainstorming call with @eAdnan007 where we had this idea that Boost has other "features" that aren't optimizations, and so they're hanging in the air somewhere.
I actually think this is going to need a follow-up PR to get rid of the "Module" terminology entirely, at least when it comes to describing Optimizations and Features. I think that distinction makes it a lot easier to reason about what belongs where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable to me, and I'm fine towards replacing Module with Feature / Optimization.