Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image: Update Ubuntu version to 21.04 #22449

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Conversation

pablinos
Copy link
Contributor

@pablinos pablinos commented Jan 21, 2022

Changes proposed in this Pull Request:

While trying to install the Jurassic Tube scripts on an M1 Mac, I was
seeing segmentation fault errors from the curl commands. After some
investigation, it looks to be a problem with libcrypto and upgrading
the base image to ubuntu:21.04 fixes the issue.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Run jetpack docker build-image
  • Check everything still functions ok
  • If on an M1 Mac, run jetpack docker exec curl https://jurassic.tube/jtuber-v0.4.sh and check that the script is returned with this change.

While trying to install the Jurassic Tube scripts on an M1 Mac, I was
seeing segmentation fault errors from the `curl` commands. After some
investigation, it looks to be a problem with `libcrypto` and upgrading
the base image to ubuntu:21.04 fixes the issue.
@pablinos pablinos added [Status] Needs Review To request a review from Crew. Label will be renamed soon. Docker labels Jan 21, 2022
@pablinos pablinos self-assigned this Jan 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update went just fine for me on an M1. I'll let @anomiex chime in to see how it goes on his system, but I think we should be good to go!

@anomiex
Copy link
Contributor

anomiex commented Jan 24, 2022

Works as far as it goes, but I note 21.04 is already end-of-life. 21.10 was released in October, so we might want to try that instead.

Also a new LTS (22.04) is scheduled for release on April 21, which we'll probably want to look at once it has come out. Too bad Ubuntu doesn't seem inclined to address this in 20.04.

@kraftbj
Copy link
Contributor

kraftbj commented Jan 24, 2022

Might as well try the jump to 21.10. I'm going to bump it to 21.10 and see if it builds for me fine. I'm not on a M1, though, so can't test for the original bug.

@kraftbj
Copy link
Contributor

kraftbj commented Jan 24, 2022

21.10 worked fine for me, so pushing up that for others to test.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works for me on M1.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Janitorial and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
@jeherve jeherve enabled auto-merge (squash) January 24, 2022 17:23
@jeherve jeherve merged commit 4838949 into master Jan 24, 2022
@jeherve jeherve deleted the update/docker-ubuntu-21.04 branch January 24, 2022 18:38
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 24, 2022
samiff pushed a commit that referenced this pull request Jan 28, 2022
Co-authored-by: Brandon Kraft <public@brandonkraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants