Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - Add plugins/backup to previous vendor copy logic #22451

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

jwebbdev
Copy link
Contributor

@jwebbdev jwebbdev commented Jan 21, 2022

Changes proposed in this Pull Request:

  • Adds plugins/backup to have vendor files copied to avoid conflicts when upgrading from 1.0.1 to 1.1.0

Jetpack product discussion

Internal references:

p9dueE-4fc-p2
p1642671449497200-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Click on the Build check below, and in the summary view click to download "jetpack-build"
  • Uncompress the downloaded archive, navigate to the Jetpack Backup plugin (jetpack-backup-plugin), and check that the files can be found at the old location (vendor/automattic/...)
  • Zip just the Jetpack Backup plugin (make sure the folder is named just jetpack-backup before zipping).
  • Create a new JN site without any plugins
  • SSH into the site, and tail the debug.log.
  • Go to Plugins > Add New > Search for Jetpack Backup and install from .org (v1.0.1) - Activate
  • Connect your site to WordPress.com from Jetpack > Backup
  • Go to Plugins > Add New > Upload plugin, and upload the zip you've just created.
  • It should offer you to update from Jetpack Backup 1.0.1 to Jetpack Backup 1.1.1-alpha (if you don't see the "this plugin is already installed..." prompt then a step was likely missed).
  • Run the update; you should see no issues on the site or in the log.

@jwebbdev jwebbdev self-assigned this Jan 21, 2022
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@jwebbdev jwebbdev requested a review from a team January 21, 2022 21:29
@jwebbdev jwebbdev added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended Build [Status] Needs Cherry-Pick and removed [Status] In Progress Build labels Jan 21, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@jeherve jeherve added this to the backup/1.1.0 milestone Jan 24, 2022
@jwebbdev jwebbdev enabled auto-merge (squash) January 24, 2022 21:06
@jwebbdev jwebbdev merged commit dace448 into master Jan 24, 2022
@jwebbdev jwebbdev deleted the update/backup-copy-old-vendor branch January 24, 2022 21:19
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 24, 2022
@jeherve
Copy link
Member

jeherve commented Jan 25, 2022

@jwebbdev If you want this to ship with the Backup 1.1.0 release, you'll want to cherry pick dace448 into the backup/branch-1.1.0 branch, so it can be automatically ported to the same branch in the mirror repo.

@sdixon194
Copy link
Contributor

Cherry picked to backup release branch in 372a611 and cleaned up in f6a15e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants