Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Package: Add watch command #22455

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

jsnmoon
Copy link
Member

@jsnmoon jsnmoon commented Jan 22, 2022

Changes proposed in this Pull Request:

  • Adds a watch command to package.json.
  • Adds a watch command to composer.json

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Run pnpm install && pnpm run watch. Ensure it builds the requisite assets as expected.
  • Run pnpx jetpack watch packages/search. Ensure it executes the same command as above.

@jsnmoon jsnmoon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Jan 22, 2022
@jsnmoon jsnmoon self-assigned this Jan 22, 2022
@jsnmoon jsnmoon requested a review from a team as a code owner January 22, 2022 00:18
@jsnmoon jsnmoon requested a review from a team January 22, 2022 00:18
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@oskosk
Copy link
Contributor

oskosk commented Jan 22, 2022

@jsnmoon Check the commands you're prompted to run on the File changes view... You've mentiond this is a minor change in the changelog file and thus the system is asking you to bump versions. So :

$ tools/fixup-project-versions.sh
$ git comit.....

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update versions here before we can merge this.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 24, 2022
@jsnmoon jsnmoon force-pushed the add/search-package-watch-cmd branch from 8e1860f to bfab5cf Compare January 24, 2022 22:56
@jsnmoon jsnmoon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 24, 2022
@jsnmoon
Copy link
Member Author

jsnmoon commented Jan 24, 2022

@oskosk @jeherve: I somehow missed the outdated version notice; thank you for the heads up! This has now been fixed.

@jsnmoon jsnmoon requested a review from jeherve January 24, 2022 23:30
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 25, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 25, 2022
@jeherve jeherve merged commit d281792 into master Jan 25, 2022
@jeherve jeherve deleted the add/search-package-watch-cmd branch January 25, 2022 12:52
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 25, 2022
@bluefuton
Copy link
Contributor

Thanks for adding this @jsnmoon! I'll update the internal docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants