Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: allow the Search team to approve changes to the package #22461

Merged
merged 6 commits into from
Jan 26, 2022

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 24, 2022

Changes proposed in this Pull Request:

  • The Search package is the work of the Search team. They're familiar with its structure and codebase, they should be able to approve changes just like Jetpack Approvers currently can.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Not much to test in this PR.

@jeherve jeherve added [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial labels Jan 24, 2022
@jeherve jeherve self-assigned this Jan 24, 2022
@jeherve jeherve requested a review from kraftbj January 24, 2022 11:14
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Search plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@jeherve jeherve enabled auto-merge (squash) January 24, 2022 11:25
anomiex added a commit that referenced this pull request Jan 24, 2022
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as written since the "Jetpack and packages" block will still require a Crew review. See on #22461 #22473 we have it looking for a reviewer at both here and here

Adding a pattern '!projects/packages/search/**' in there (around line 24-ish) to exclude the search package from that block should fix it.

@anomiex anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
@jeherve
Copy link
Member Author

jeherve commented Jan 25, 2022

thanks for catching that! Pushed your suggestion in 78bd530

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 25, 2022
@anomiex anomiex disabled auto-merge January 25, 2022 15:37
anomiex
anomiex previously approved these changes Jan 25, 2022
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one (optional) suggestion inline

Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@kraftbj kraftbj enabled auto-merge (squash) January 25, 2022 16:41
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 26, 2022
@kraftbj kraftbj merged commit cbaf0d6 into master Jan 26, 2022
@kraftbj kraftbj deleted the update/approvers-search-package branch January 26, 2022 12:45
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 26, 2022
@github-actions github-actions bot added this to the search/0.1.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants