Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track user clicks on Links/Buttons in disconnect modal footer #22467

Merged
merged 10 commits into from
Jan 31, 2022
Merged

Track user clicks on Links/Buttons in disconnect modal footer #22467

merged 10 commits into from
Jan 31, 2022

Commits on Jan 24, 2022

  1. [not verified] Track user clicks on disconnect dialog modal

    @jim-coffey
    jim-coffey committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    3b23238 View commit details
    Browse the repository at this point in the history

  2. Fix and add some unit tests

    @jim-coffey
    jim-coffey committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f7e1476 View commit details
    Browse the repository at this point in the history

  3. Changelog

    @jim-coffey
    jim-coffey committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    47f11b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. changes based on review comments 

    - rename stay connected handler
- move all click tracking code to step-disconnect
    @jim-coffey
    jim-coffey committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8bd68b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Update based on comments 

    - fix tests to loop and be less brittle
- stop constructing event names programmatically
- some formatting
    @jim-coffey
    jim-coffey committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    415f693 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add/disconnect-modal-click-events

    @jim-coffey
    jim-coffey committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d20abe9 View commit details
    Browse the repository at this point in the history

  3. version fixup script

    @jim-coffey
    jim-coffey committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    b6fd563 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Merge branch 'master' into add/disconnect-modal-click-events

    @jim-coffey
    jim-coffey committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    abc081b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add/disconnect-modal-click-events

    @jim-coffey
    jim-coffey committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    2bf7c6d View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. [not verified] Merge branch 'master' into add/disconnect-modal-click-… 

    …events
    @jim-coffey
    jim-coffey committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    472e862 View commit details
    Browse the repository at this point in the history