Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add missing nyc dep when creating JS packages #22471

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 24, 2022

Changes proposed in this Pull Request:

When creating a JS package, the CLI is pre-filling the test-coverage
script with a call to nyc. But it wasn't also pre-adding a dependency
on nyc, resulting in coverage not working for several packages.

Also, add the missing dep to those packages.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

When creating a JS package, the CLI is pre-filling the test-coverage
script with a call to `nyc`. But it wasn't also pre-adding a dependency
on nyc, resulting in coverage not working for several packages.

Also, add the missing dep to those packages.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Jan 24, 2022
@anomiex anomiex self-assigned this Jan 24, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73664-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@anomiex
Copy link
Contributor Author

anomiex commented Jan 24, 2022

I spotted this while looking into why the coverage job has started hitting its time limit. This'll probably actually make that problem slightly worse, but it needs to be fixed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kraftbj kraftbj enabled auto-merge (squash) January 24, 2022 23:17
@kraftbj kraftbj merged commit 8a829ce into master Jan 24, 2022
@kraftbj kraftbj deleted the add/missing-nyc-deps branch January 24, 2022 23:17
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jan 24, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D73664-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Jan 25, 2022

r238858-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants