-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Update data handling - Implement request status in Product Card #22475
My Jetpack: Update data handling - Implement request status in Product Card #22475
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
4a5acd7
to
8494a36
Compare
8494a36
to
9c1c8ac
Compare
9c1c8ac
to
1a81bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just remembered that I'm not the best one to review the PHP side, so could be good for another person looking at it.
Thanks for your review. I think we are ok since @leogermani took a look, and even more, he added some changes here, too. |
Fixes #
Changes proposed in this Pull Request:
This PR updates the data handling implementation for the Products;
/site/products/$product
endpointJetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Screen.Recording.2022-01-24.at.7.15.28.PM.mov
You can hardcode the response for both for the
activate_product()
anddetivate_product()
methods respectivelyfor the
detivate_product()
methodScreen.Recording.2022-01-24.at.10.01.31.PM.mov