Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search dashboard: add scaffolding for Record Meter #22497

Merged
merged 10 commits into from
Feb 3, 2022

Conversation

bluefuton
Copy link
Contributor

@bluefuton bluefuton commented Jan 26, 2022

Changes proposed in this Pull Request:

Add scaffolding for Record Meter feature in wp-admin's search dashboard.

Todo:

  • Add feature flag

Jetpack product discussion

pcNPJE-iq-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

On a site with Instant Search enabled, load the search dashboard with features=record-meter in the query string:

wp-admin/admin.php?page=jetpack-search&features=record-meter

You should see the 'Your search records' title like shown:

Screen Shot 2022-01-28 at 17 56 56

Now try with some old nonsense in the features param, like spaniels, or omit the param altogether.

wp-admin/admin.php?page=jetpack-search&features=spaniels

You should not see the 'Your search records' title at all:

Screen Shot 2022-01-28 at 17 57 11

cc @annacmc

@bluefuton bluefuton added [Status] In Progress [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Jan 26, 2022
@bluefuton bluefuton self-assigned this Jan 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

@bluefuton bluefuton marked this pull request as ready for review January 28, 2022 05:01
@bluefuton bluefuton requested a review from a team as a code owner January 28, 2022 05:01
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 28, 2022
annacmc
annacmc previously approved these changes Jan 31, 2022
Copy link
Contributor

@annacmc annacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a spin and it's working as expected for me 👍

When I tried with no query string I could not see 'Your search records' title at all, nor when I added some other nonsense query strings such as features=spaniels

It does display Your search records correctly when I add features=record-meter

Gave it a test in Safari, Chrome & Firefox as well as firefox iOS on mobile. Works well in all cases 🎉

@bluefuton bluefuton added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Jan 31, 2022
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, but will require a tweak to pass all the required checks.

@jsnmoon jsnmoon added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 31, 2022
@bluefuton bluefuton added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 1, 2022
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 1, 2022
@bluefuton bluefuton added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 1, 2022
jeherve
jeherve previously approved these changes Feb 2, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@jeherve jeherve enabled auto-merge (squash) February 2, 2022 16:28
@jeherve jeherve added this to the jetpack/10.7 milestone Feb 2, 2022
jeherve
jeherve previously approved these changes Feb 2, 2022
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving following a lockfile update

@jeherve jeherve merged commit 1557a93 into master Feb 3, 2022
@jeherve jeherve deleted the add/record-meter-scaffolding branch February 3, 2022 22:46
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants