-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search dashboard: add scaffolding for Record Meter #22497
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
af4dd27
to
75e0ff5
Compare
25dc58d
to
4bdcd1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a spin and it's working as expected for me 👍
When I tried with no query string I could not see 'Your search records' title at all, nor when I added some other nonsense query strings such as features=spaniels
It does display Your search records
correctly when I add features=record-meter
Gave it a test in Safari, Chrome & Firefox as well as firefox iOS on mobile. Works well in all cases 🎉
647cfcd
to
af2269c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described, but will require a tweak to pass all the required checks.
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
45aac69
to
e91d6de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving following a lockfile update
Changes proposed in this Pull Request:
Add scaffolding for Record Meter feature in wp-admin's search dashboard.
Todo:
Jetpack product discussion
pcNPJE-iq-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
On a site with Instant Search enabled, load the search dashboard with
features=record-meter
in the query string:wp-admin/admin.php?page=jetpack-search&features=record-meter
You should see the 'Your search records' title like shown:
Now try with some old nonsense in the
features
param, likespaniels
, or omit the param altogether.wp-admin/admin.php?page=jetpack-search&features=spaniels
You should not see the 'Your search records' title at all:
cc @annacmc