Widget Visibility: ensure we find the correct site type

[jeherve]

Changes proposed in this Pull Request:

We previously relied on wpcom, which unfortunately won't work here; it does end up being defined even on Jetpack sites, because of the additional scripts from WordPress.com that are enqueued in the admin.

This was reported here: p8oabR-Nm-p2#comment-5896

Jetpack product discussion

• N/A

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• You'll want to test this on wpcom simple as well as Jetpack
• In Jetpack > settings, ensure the Widget visibility feature is active.
• go to Appearance > Widgets
• Add a block
• in the right block sidebar, scroll down and open the "Advanced" panel.
• Add a visibility rule
• in the options, you should see the option to filter by user role, or to check whether the user is logged in or not.
  • On WordPress.com, those options should not appear.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73881-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: March 1, 2022.
• Scheduled code freeze: February 22, 2022.

[samiff]

I could be missing something, but could the existing isSimpleSite() util be used here?

jetpack/projects/plugins/jetpack/extensions/shared/site-type-utils.js

Line 27 in 2e04966

export function isSimpleSite() {

[jeherve]

Unfortunately since it's not part of the same bundle (Blocks vs. Widget Visibility), we cannot fully rely on it. That's what I started from here though. In the future, and once we have a shared utility like in #22505, we could use it in both places.

[samiff]

Got it, I haven't delved into the webpack setup so just assumed it would be imported and bundled up. Thanks for the explanation 👍

[jeherve]

Now that this was moved to an external js package, we can import it instead of duplicating it! 🥳 #22741

[samiff]

Tested that user/role options showed up on a WPorg site, but were hidden on simple wpcom.

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D73881-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[samiff]

r239359-wpcom