-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Refactor build and install commands #22538
Conversation
This lays some groundwork for future PRs that will run builds in parallel, prefixing each line output with the appropriate slug. The helpers in `helpers/tasks/installProjectTask.js` weren't all that helpful anymore. Instead we provide some lower-level functions in `helpers/install.js` that can be built upon for the slightly different future requirements of install versus build. Install no longer confusingly reports that it's installing pnpm dependencies for every package being installed, instead doing a single `pnpm install` task at the top level. Install no longer behaves weirdly when passed both `--root` and `--all`. Build gets an `--all` option (because it was easy to add), and an option to skip the `pnpm install`. Build also handles its own output in verbose mode (rather than using listr-verbose-renderer) in preparation for parallel builds. Due to the abstracting of `jetpack install --all` and `jetpack build packages`, those commands now also accept multiple packages on the command line.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried various install and build combos, works smoothly.
Great news! One last step: head over to your WordPress.com diff, D73941-code, and commit it. Thank you! |
r239097-wpcom |
Changes proposed in this Pull Request:
This lays some groundwork for future PRs that will run builds in
parallel, prefixing each line output with the appropriate slug.
The helpers in
helpers/tasks/installProjectTask.js
weren't all thathelpful anymore. Instead we provide some lower-level functions in
helpers/install.js
that can be built upon for the slightly differentfuture requirements of install versus build.
Install no longer confusingly reports that it's installing pnpm
dependencies for every package being installed, instead doing a single
pnpm install
task at the top level.Install no longer behaves weirdly when passed both
--root
and--all
.Build gets an
--all
option (because it was easy to add), and an optionto skip the
pnpm install
.Build also handles its own output in verbose mode (rather than using
listr-verbose-renderer) in preparation for parallel builds.
Due to the abstracting of
jetpack install --all
andjetpack build packages
, those commands now also accept multiple packages on thecommand line.
Jetpack product discussion
PT: p9dueE-4dJ-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
jetpack install
,jetpack build
, andjetpack test
commands. Do they still work in various use cases?