Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Add timing to build output #22539

Merged
merged 4 commits into from
Jan 28, 2022
Merged

cli: Add timing to build output #22539

merged 4 commits into from
Jan 28, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 27, 2022

Changes proposed in this Pull Request:

jetpack build --timing will now output timing information for each
completed command. With --verbose, it will also prefix each line of
output with the time since the start of the task.

Jetpack product discussion

PT: p9dueE-4dJ-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try jetpack build's new --timing option. Does it work correctly in various use cases?
  • Check the Build job logs, does the timing information show up properly there?

@anomiex
cli: Refactor build and install commands
a7ba840 
This lays some groundwork for future PRs that will run builds in
parallel, prefixing each line output with the appropriate slug.

The helpers in `helpers/tasks/installProjectTask.js` weren't all that
helpful anymore. Instead we provide some lower-level functions in
`helpers/install.js` that can be built upon for the slightly different
future requirements of install versus build.

Install no longer confusingly reports that it's installing pnpm
dependencies for every package being installed, instead doing a single
`pnpm install` task at the top level.

Install no longer behaves weirdly when passed both `--root` and `--all`.

Build gets an `--all` option (because it was easy to add), and an option
to skip the `pnpm install`.

Build also handles its own output in verbose mode (rather than using
listr-verbose-renderer) in preparation for parallel builds.

Due to the abstracting of `jetpack install --all` and `jetpack build
packages`, those commands now also accept multiple packages on the
command line.
@anomiex
cli: Add timing to build output
c3c2c34 
`jetpack build --timing` will now output timing information for each
completed command. With `--verbose`, it will also prefix each line of
output with the time since the start of the task.
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Feature Request [Pri] Normal labels Jan 27, 2022
@anomiex anomiex self-assigned this Jan 27, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73942-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Jan 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Base automatically changed from update/refactor-cli-build-install-commands to master January 27, 2022 21:38
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 27, 2022
@jeherve jeherve enabled auto-merge (squash) January 28, 2022 10:56
@jeherve jeherve merged commit 1af5545 into master Jan 28, 2022
@jeherve jeherve deleted the add/cli-build-timing branch January 28, 2022 11:11
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D73942-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 28, 2022
@anomiex
Copy link
Contributor Author

anomiex commented Jan 28, 2022

r239125-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@anomiex anomiex

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. Touches WP.com Files [Type] Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anomiex @matticbot @kraftbj @jeherve